Skip to content

CI: enforce changelog in dedicated commits and add shellcheck#39

Merged
dannywillems merged 2 commits intomainfrom
ci-changelog-commit-check
Feb 8, 2026
Merged

CI: enforce changelog in dedicated commits and add shellcheck#39
dannywillems merged 2 commits intomainfrom
ci-changelog-commit-check

Conversation

@dannywillems
Copy link
Contributor

@dannywillems dannywillems commented Feb 8, 2026 •
edited
Loading

Summary

  • Add .github/scripts/check-changelog-commit.sh that verifies:
    1. CHANGELOG.md changes are in their own dedicated commit
    2. Commit hashes referenced in new entries exist in the repository
    3. Commit link URLs match their reference keys (no stale URLs)
  • Add shellcheck CI job using make lint-shell
  • Add make lint-shell Makefile target

Closes #35
Closes #36

Test plan

  • A PR with CHANGELOG.md modified alongside other files in the same commit should fail
  • A PR referencing a non-existent commit hash in CHANGELOG.md should fail
  • A PR with a link like [abc1234]: .../commit/xyz7890 (mismatched) should fail
  • A clean PR should pass all checks
  • make lint-shell should pass locally and in CI

@dannywillems
CI: enforce CHANGELOG.md hygiene in pull requests
d30efd2 
Adds check-changelog-commit.sh that verifies:
1. CHANGELOG.md changes are in dedicated commits
2. Referenced commit hashes exist in the repository
3. Commit link URLs match their reference keys

Also adds shellcheck CI job and lint-shell Makefile target.

Closes #35
Closes #36
@dannywillems
CHANGELOG: add entry for changelog hygiene CI (#35, #36)
34c970d
@dannywillems dannywillems force-pushed the ci-changelog-commit-check branch from f96eddc to 34c970d Compare February 8, 2026 00:26
@dannywillems dannywillems merged commit f8f51bd into main Feb 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: verify commit hashes in CHANGELOG reference actual branch commits CI: enforce CHANGELOG.md changes are in dedicated commits

1 participant

@dannywillems